Junior Developer Sent Me A PR For Review

In this video, we'll take a look at a pull request (PR) submitted by a junior developer for review. As a more experienced developer, it's important to provide constructive feedback to help junior developers learn and grow. We'll walk through the PR step-by-step and discuss best practices for reviewing code changes.

Whether you're a junior developer looking to learn more about code review, or an experienced developer looking to improve your reviewing skills, this video has something for everyone. Join us as we explore the world of code review and help junior developers take their coding skills to the next level!

Don't Forget to
===========================================

🙊 Here are the goods for all my videos video 🙊

► Recommended Books
===========================================

► Computer and Monitor
===========================================

► Camera Gear
=============================================

► IDE & Tools I use for coding 💻 🎒
===========================================
- ITerm
- VsCode
- GoLand
- IntelliJ Ultimate
- Sublime

P.S
===========================================

❤️ Thanks for watching

[dimpho.ngache]

This got me thinking that maybe interviewing developers by allowing them to review a PR like this and explaining their suggestion will reveal a lot about their competence.

[petroniobonavides]

This is awesome!!!! Watching this video we can see, what a senior developer, think about a junior developer code. And... Paying attention in those tips/movements, we can Our code!!! EUREKA!!! Actually, It deserve a playlist

[suikast]

6:57 You suggest a RuntimeExcpetion as base class. It's ok at first. But every Project should have at least one base type of it's BusinessException which extends from RuntimeExpcetion. This makes the error handling in the rest controlelers and the transaction rollback handling for specific use cases relay easier.

[Elvis-is-king-ls]

Always good to watch PR reviews but IMO it Would be good to add explanation on top of code changes in the comments otherwise it is hard/impossible to understand why the changes are required/suggested

[jorgeromero]

9:13 Actually the HTTP Protocol nowhere states that you shouldn't return the resource back. You can return the created resource in this case "User" as long as you provide the identifier with it.

[ogookafor]

There are no videos like this out there. Please more of these videos. This was very interesting.

[christopherbryant]

You should do this more often! Very helpful!! Thanks

[videohighlights]

The code is returning entity via REST, which is BAD. Not sure why wasn't it called out. As the project progresses and the User will have `password` field in it, it will also be returned back via REST. The entity should be converted to DTO.

Also, Lombok should be used to validate field values. No need to validate them in service layer i.e., if email exist or not. Service layer can be used to validate business logic.

[caffeinejavacode]

Review took 15 min
I can't even imagine how much time it takes to review sophisticated business logic with 15+ pages or more

[Norua]

Also it is a good practice of returnung DTO's instead of entities

[ringishpil]

Hey Amigos! Greetings from a fellow senior developer. I have to say I completely disagree with how you did the review. Considering this is a fellow junior engineer, all you did is point where he did the mistake and not why he did it. At the end when you suggested to check if email is taken, you should’ve suggested how. Is that a new func? Is it an ON CONFLICT query? And what if its taken? Would you leak out that information to the client?

I think the most important thing at PR review is the WHY which according to me you failed to deliver

[Fortuna]

As a junior developer, I made note that a lot of the comments/suggestions you left on the PR didn't have explanations why lines should be modified, added or removed. Is this something you talk about at length outside the PR to teach your developers why those changes should be made?

[scottserage]

The thumbnail really worked for this lol, I probably overlook all sorts of bad coding practices and redundant or overly complicated code but that no new line eof drives me bonkers 😂

[dad]

Had a little chuckle at the end, "theres no way this PR makes it's way into the main branch.". I work at a major bank, and you'd be amazed at some of the shit that gets yolo merged...

This video should be a mandatory watch, even for seasoned devs

[deshpasheeto]

Hiya! Would really like to watch more of such videos where you do a live Review with us. This is really very helpful. Please keep them coming. Thank you

[aayush]

Thanks buddy, watching code reviews really helps us improve!

[Im_not_scareddd]

This is awesome bro. It was my first time to see code reviewing. It really motivated me bro. tnx a bundle

[abu-dukhan]

Maasha Allah, that's so interesting, even though I'm not a pro but I understand and I'll also take note of these mistakes, I really wanted to grow my java knowledge because when I was in university almost everyone hates Java, and I don't know how Allah makes it easier to me, and following your tutorial really opened my eyes to what Java really is, but still I wasn't able to purchase even one of your course due to our economy situation, but believe me I have almost all your YouTube videos (Spring boot related) download on my PC.
And in Sha Allah I'll try to share my work based in what I learnt from just the YouTube videos, but that'll be after you permit me to.
I don't have enough words to show my gratitude to you but only Allah will reward you abundantly. JazaakAllahu khairan

Yunus from Nigeria

[gabrielalvesgoncalves]

These videos are very good, it would be really cool if they happened more often

[matheusnicoas]

I would suggest to remove the code with endpoint comments because swagger can doc the endpoints with more details (request, response, endpoint, etc) but it's not a big deal (I'm sorry if looks like nitpicking, that's not the idea). Awesome video, I'm a developer for 6 years and I'm focusing on leave Brazil and move to UK or Ireland in the next months, I really appreciate your content, thanks for that!