Junior Developer Sent Me Another PR For Review

In this video, we'll take a look at a pull request (PR) submitted by a junior developer for review. As a more experienced developer, it's important to provide constructive feedback to help junior developers learn and grow.

We'll walk through the PR step-by-step and discuss best practices for reviewing code changes.

Whether you're a junior developer looking to learn more about code review, or an experienced developer looking to improve your reviewing skills, this video has something for everyone.

Join us as we explore the world of code review and help junior developers take their coding skills to the next level!

Don't Forget to
===========================================

🙊 Here are the goods for all my videos video 🙊

► Recommended Books
===========================================

► Computer and Monitor
===========================================

► Camera Gear
=============================================

► IDE & Tools I use for coding 💻 🎒
===========================================
- ITerm
- VsCode
- GoLand
- IntelliJ Ultimate
- Sublime

P.S
===========================================

❤️ Thanks for watching

[SachalChandio]

Hands down you are the best online mentor I've ever come across. Keep doing the amazing work.

[abubakaramasa]

Salam bro, coming from a node js background to java, u've made my transition extremely easy. Learnt a lot from you this short period, keep it up. 💯 just had to leave this here

[smarttrupti]

Could you please make a video on how to handle exceptions well at all layers controller, service and repo with correct way of setting the response and correct status code? And if possible to include global exception handling? Would really appreciate. Thank you.

[ujwalborle]

Dieses Programm hat meine Produktivität enorm gesteigert. Vielen Dank, dass Sie es zugänglich gemacht haben.

[hovhannes]

I just reviewed some code with these exact issues last week. You can just just default provider everywhere, never need spring-cloud-aws. Just set the environment variables at deploy time or specify a profile that on-startup performs a System.setProperty(...) on the data you get from startup variables or a profile-specific propertied file. Also I always enforce a null-check at startup using InitializingBean or PostConstruct. You want to know about required variables that are missing immediately, not when the machine might have already been spinning for a few hours. 100% agree with all your points, learned something new today about proper controller structure too :)

[Nimkrox]

Your videos are amazing, thank you for recording them :D
If you're looking for ideas for the next videos, I would be grateful for:
1. examples of some of the most used design patterns (like factory method, abstract factory, builder, prototype, ...) with an explanation of why we should use them in certain cases and when using a design pattern is a bad idea. For me, it's tough to recognize situations when I should use a specific design pattern and when I shouldn't because it will only cause complications in the code.
2. hacks & tips on how to debug like a pro

[abhishekrai]

I generally check for following things :
#1 API specifications, error handling (not throwing exception to client)
#2 security concerns
#3 generic code and not too specific, but also not complicating things
#4 use of design patterns - strategy, factory, facade, visitor, pub-sub (mostly use Kafka if already in system), decorator (yes, annotations)
#5 good documentation for complex functions with any assumptions taken
#6 Error handling with segregation into 3xx, 4xx, 5xx codes
#7 better use of language specific constructs - Scala, Kotlin, Java (lesser code variants in all 3)
#8 segregation and maintainable of code structure
#9 decent logging and monitoring/metrics at Grafana, Kibana, Hadoop end
#10 use of threads - depends on use case

[michelchaghoury]

We need more Spring Boot Microservices, AWS, Angular and DevOps tuts please and thank you for the great content.

[bartuchy]

What about ControllerAdvice? Isn't it better or more ellegant way to handle exceptions, instead of try/catch in service methods?

[santiagosuarez]

Yoo thx, this is one of the best PR review i saw. I am developer java than work with aws, and i did't know that kind of function to s3 secret key. Thx bro!

[francescobucciol]

Usually the video are very basic. This instead I found more enlightening, especially on the AWS credendials part (on working right on that currently).

[mohamedmhiri]

Waalaykom al Salam, great job.
I have some more tips:
- ImageService from line 33 to line 37 could be replaced with a custom controller taking in parameter the id, type, date and customer (encapsulation)
- I would use interfaces rather than classes as much as we can to ensure that the code is not highly coupled with amazon technologies

[lwa.dev]

Hi Nelson, wow, this was great to watch and learn as you went through the pull request; I have never had that experience myself as I have been trying to learn on my own but always found many roadblocks and tried to work around them but lost a little faith along the way but still keep trying as I know this is the way. I pray Allah will give me the courage to continue as I believe it is possible. I have always watched your content, and now I know you have paid courses I can take to achieve my goals for the future. The developer roadmap on AmigosCode has given me a visual overview of what I need to focus on. I never thought about Java, but I know of JavaScript. Thank you for bringing this content to many such as myself—blessings to you, my brother.

[SerhiiPylypenko-ow]

Very valuable observations. Will review again to remember well. Thanks a lot!

[kaan]

Hey Amigoscode, I enjoy your videos very much. I had a request. Could you make a video on how to make a good CV for a Java Developer with no work experience? That would be awesome if you would make one!

[MaksRybalchenko]

As for exceptions I would recommend to create your own exceptions (would be a bit more clear in term of logic ) throw them and handle them in global exception handler.

[maksym.pavlenko]

What's the argument behind avoiding the use of mocks in that test?

[freedomoflife]

assalamu'alaikum, great video as always, thanks from Indonesia ❤‍🔥

[Mars-fmni]

at 07:35 isn't it better to use a builder for the media Class? Also we use final for our method parameters.

[tailevan]

As you are reviewing your current project, I see that you are still using ResponseEntity, so I have a question as to why the projects I am working on have to custom a response instead of using ResponseEntity, or is ResponseEntity available? some downside, please explain to me, thanks