Senior developer reviews junior developer's code

Senior developer @GuilHernandez reviews a junior developer's code and teaches them how to level up and make their code more efficient and terse with event delegation (event bubbling) 📈

00:01 Introduction
01:14 Guil and Micha meet
04:26 Senior developer reviews junior's code
20:21 Outro

MEET WITH GUIL AND GET YOUR CODE REVIEWED

OUR FREE ONLINE COURSES

SCRIMBA PODCAST
☝️ You can find it by searching "Scrimba pod" on any podcast app

SAY "HI" ON TWITTER

CONNECT ON LINKEDIN

ABOUT SCRIMBA
Scrimba's goal is to create the best possible coding school at the lowest possible cost for students. If we succeed with this, it’ll give anyone who wants to become a software developer a realistic shot at succeeding, regardless of where they live or the size of their wallets.

Our YouTube channel features live streams with industry experts, weekly vids on how to become a developer and our Friday night live-code frivolity. We hope you enjoy! 💜 💻

OTHER LINKS

[NhiNguyen-mehm]

Scrimba teamm, please do more video about code review like this one. This is awesome!!! 🎉

[richchar]

More code review videos! This was great 👏👏

[ganta]

Oh my, this code review was awesome !
I did some really similar code to micha's and indeed I can make really good improvements on it. I really learned new things heres that I never heard before.
Thank you Guil for been an awesome instructor. That concise and calm way of teaching and explaining the code is really important.

[muhmmadawd]

wow, i like this instructor he is very lovely

[waqaskhandev]

I feel so satisfied. Please share more videos like this

[KristianTheDesigner]

Im gonna apply these techniques first thing in the morning in the current project assignement i am working on 🤓👍 superhelpful

[edy]

Awesome use of the event delegation/bubbling to make to code DRY. Also, I had no idea about the way the conditional was added in the toggle method to shorten code. This was great, I would like to see more code reviews explained like this !

[mykalimba]

19:47 On lines 37-38, instead of removing the highlighter class manually, just call the highlight() function.

[PaulSebastianM]

I think I would have used a discriminator instead of differently named data attributes. So, let's say data-value="1..3" and data-team="home" or "guest". The you have just one top level if in the event handler to discriminate on which team to add the points to, instead of 2, and you would use all the data attributes that you queried, not have one that is always fetched but not used.