How to Review Code | Best Practices | Pull/Merge Requests | iOS | Swift | Checklist

In this video, I have discussed about the things which we should keep in mind while reviewing the code (pull/merge request). Apart from this, I’ve also discussed about creating Pull/Merge requests, how to apply merge checks, best practices and compiled all the checks in an exhaustive checklist. Also, demonstrated each check with an example (by reviewing a dummy PR).

Checklist 👇🏼

Chapters 👇🏼

00:00 Start
01:53 What’s there in the video.
02:16 Brief about demo project
03:34 How to apply merge checks
05:00 PR Creation
07:00 PR Review
07:58 Unnecessary Imports
08:15 Protocol Conformance in Extensions
09:25 Typo Checks
09:52 View should not have Data Object
10:25 Type Inference
11:46 Responsibility Division
12:00 Naming of the Variables
12:43 Single Responsibility - Different methods for different tasks.
13:10 Unnecessary Checks
14:40 Consider edge cases (keep fallbacks) - Error Handling
15:30 Write code for maintainer
16:24 Hard Coded Values
17:24 Prefer Enums, Switch over if/else
18:30 Use APIs provided by Apple
19:20 Check for Force Unwraps (Prefer Optional Binding)
20:02 Check for Indentations
20:50 Check for efficient Memory Managment (avoid retain cycles)
21:26 Avoid using deprecated APIs
21:56 Dependencies should be injected
23:03 DRY (Don’t Repeat Yourself)
24:08 Prefer Higher Order Functions
25:35 YAGNI Principle (You Aren’t Gonna Need It)
27:33 Early Returns wherever possible
28:15 Check Array’s count before accessing the elements
29:09 ViewModel Should Only Have Business Logic
29:31 Unintended Changes
31:00 Boy-Scout Principle
32:55 Code Review Checklist

[JonatanEdOrtiz]

I believe it's good practice to also explain the reason for requesting the change in each comment, that way more junior devs can learn new concepts and apply them to their future code.

[-ck]

When given code reviews as a Senior or team member, it’s generally good practice to include sample code snippets along with your feedback. Simply pointing out poor practices is half the journey.😊

[sunnysinha]

I love the way you explain. 
Generally we forgot most of the point while coding but the way you explained every point with an example will remain in mind.
Thanks a lot.
Will expect more interesting content from you😊

[archanabhosale]

I was looking for one proper process for code review and you have given exactly that. Thanks for your inputs.

[TechRagh]

Thanks Pallav, please keep posting more and help us to learn more 😊

[price_action_wale_baba]

Hi Pallav, It is great that you provide extreme information free of cost. First of all Love from the heart brother.

I follows you for the last month only. I have learned lots of things from you and I'm trying to implement them in real client projects.

I have created many demos to be a better Sr. iOS Developer, but I was struggling. After checking every single video, I can see improvement. Your style of passing information is very easy and simple to understand complex things.

Please create a video on a learning path. Like where to start, what to learn, and how to learn. Because every developer missed this path and was stuck between multiple topics.

[saurabhsierra]

Yeah... that's right ...even the smallest mistake breaks the code...i was really searching for something that can help mitigate the same ...thanks for the same again ....once again Awesome tricks to mitigate the code gulping mistake .

[krishnendramishra]

Your series are always have some unique content ... Thanks for making unique content for iOS developers.

[rehanismail]

It’s Best tutorial. I ever found related to Code Review learning. Keep it up bro waiting for your next tutorial.👍

[RahulKumar-hrgq]

Sir please keep going. You are helping a lot of people(Developers) to gain free of cost very information knowledge. :)

[KimbrellBrad]

Great list! I have not been exposed to CR but wanted to ask someone to take a look. Now I can be ready to look at their code as well. Thanks for the tips!

[pushpabisht]

Very much useful, thanks a lot Pallav for this video.

[ViktorMameshyn]

Great suggestions, Pallav! Thanks for the useful video, I'll definitely keep watching your next issues :)

[alex_undr]

nice video bro! u got my subscription!

[shmalesmal]

great and clear explanation! thanks for sharing this. greetings from Ukraine!

[rajasekarangopal]

Thanks Pallav. it was very informative.Keep inspiring US 👍🏻

[JLCodes]

at 8:15 of this video, you mentioned to check if there are any unnecessary imports. `Foundation` is unnecessary when `UIKit` is imported already since UIKit contains Foundation.

[sakirsaiyed]

Very good observations... keep it up. nice content.

[Rahul-jfkf]

Nice video Pallav, with step by step explanation.
Can you make video on iOS app UI Design using storyboard or share some links for UI Design.
also please make video on storyborad code review.

[HumbleHustle]

Good video. I think returning tuple from a method does not promote readability rather a struct should be returned.