How to make a GOOD Code Review?

Senior Dev explains: Code Reviews are bread and butter of software developers job, but how many of us know how to do it right? I have picked up a lot of great practices over the years - I'm sharing some in this video.

To answer how to give a GOOD code review - there are some pressing questions we'll cover in this video:
00:55 How code review is done?
01:13 When it is OK to decline a code review?
01:41 How much time should you spend on code review?
02:10 Well, what is a code review (and what it isn't!)?
03:27 What are the steps of good CR?
04:00 How to read the code?
04:30 How to correctly give comments ?
(So you don't lose points in the team and still get your message across!)
06:30 What do you need a summary for?

[MrKret]

I don't need any code review, I know my code sucks.

[yuriyzhdanov]

Thank you for your simple English. I can understand everything.

[TravellingFox]

Thanks for making this video. I am gonna show it to my colleagues because you explain the heart and spirit of code reviews so much better than I can possibly do it. =^, ^=

[RockRiffManiac]

Such a detailed and enjoyable video! More people need to watch this

[CoderFoundry]

Great Video with great tips. Being nice is an often overlooked superpower.

[aliBoumedyen]

I like the tips about good comments, Good stuff!!

[robertm]

Great video and excellent tips for writing code reviews.

[PierreLaBaguette]

This video has some psychological insights and tips that aren't mentioned in other similar videos. Smart/wise and super useful. Thanks for those too, man!

[helloroman]

„I think you forgot G” – That's what she said. Michael Scott would say 🤣 Congrats on reaching 10k subs. Your channel is really amazing ❤️ Respect!

[JavierLunaMolina]

I really enjoyed the video!
I don't know what's your company's policy on who reviews which code, but I found that if you can choose, people tend to choose good reviewers over bad ones who just approve the changes :)

When code reviewing, what do you do if you find some code that isn't in the patch but doesn't comply with your quality standard? Do you comment on it for the author to fix it on the same PR or would you just create a task to work on it later?

Thanks for the video!

[anicolaspp]

where can I get that mechanical keyboard?

[robinbouwmeester]

Do you should run and test the changes as a reviewer? Like a whitebox test? We have a testing phase, but this is only blackbox integration test. I experience many pull requests that have unittests with their commit, but when I do an integration test manually the change doesn’t even work 100%. Any suggestions?

[alvarobazan]

I’m working Towards my bachelors in computer science and have 2.5 years left in my program hopefully specializing in block chain technology . Watching your videos are extremely motivating

[aknerkan]

I see what did you do there 02:53 LOL!

[kekekeernest]

2:53 - 3:02, THIS 😂😂😂😂, i thinks that is a way better comments

[igorsk]

3:00 the most ridiculous part, is this about video editing or code review? :)

[AhmedHussein-ricm]

Great tips !


Smok, could you please make a video of how we use advanced data structures and different Algorithms in daily tasks in "Big Companies", this could be possible ?


I know that FAANG companies hire Engineers who have a high understanding of DS and Algorithms


Can a junior engineer join these companies ? can I dream of something like this ?

as a Senior Engineer, what do you expect from me to know and understand while making an Interview for me.


Sorry for my strange questions, hope you are fine with them :)


Your help is highly appreciated, thanks in advance

[carlosbp]

When people understand that code review is just a tool for teaching to write better code is awesome.

[rachel_adams]

Code reviews have a tendency to become toxic and are often used as a weapon to attack the developer rather than educate. It's my opinion that code review is taken too seriously, its not as important as it’s made out to be. Instead of focusing on the nit-pick of the day, it would be more useful to run the persons code to check the work meets the functional requirements set out in the user story.