How to Review a Pull Request in GitHub the RIGHT Way

In this video I will teach you how to review a pull request in GitHub the right way.

In this GitHub pull request tutorial, we will discuss GitHub start a review vs add single comment, and how to code review on GitHub. If you want to know how to do a pull request review, this is the video for you!

🆘 NEED HELP? 🆘
We can talk about GitHub, Azure DevOps, or any other DevOps tool or project you need help with!

🙏🏻SUPPORT THE CHANNEL🙏🏻

💬JOIN THE COMMUNITY

🎥VIDEOS

⏲TIMESTAMPS
0:00 Intro
0:41 PR done wrong
2:13 PR done right
3:55 Conclusions

❓QUESTIONS?
Have a question about DevOps, Cloud, Coding, or Anything Else? Post in comments section of this video!

_______________

🔮TOOLS I USE

📸🖥️GEAR AND SOFTWARE

Disclaimer:
Some product links are affiliate links which means if you buy something I'll receive a small commission at no additional cost to you.
As an Amazon Associate, I earn from qualifying purchases.

[CoderDave]

🆘 NEED HELP? 🆘
We can talk about GitHub, Azure DevOps, or any other DevOps tool or project you need help with!

🙏🏻SUPPORT THE CHANNEL🙏🏻

[KarlBrouillette]

Thank you very much! 3 mins and I am off to do my review. Very efficient :-)

[Chatsworth]

Ah, another "three minute Thursday here in the US" : - ) Seriously, I like these and know why you post them at this time. A good one today!

[missthi]

On very large PRs I prefer the individual comments because then we can work in parallel: the other developer can already start thinking about my comment and potential changes, while I can continue reviewing.
But I guess for smaller ones I should use the Start a review. Also will try the "suggestion" function, havent done that yet 😅

[LordKaos]

Thank you very much for the video. Very useful.

[SainiranjanGajula]

Hey Dave, thanks for the video. After getting email notification from the reviewer, how do I fix changes ?
1. Do I update the PR fixes within the git ? (which will be big hassle)
2. Raise new PR with the fixes ?

Please do advice and if possible please make a video. Thank you!

[dongwalker]

thank you so much！I'm new to code review and this video helps me know how should i start it

[curiousteambd]

Great in short. Thanks a lot. I was searching for it.

[frankjoel]

Hey there, I think this is a great introduction, to me more complex questions arise.
So: Like as you've mentioned, usually there are bigger PRs, so there are like 20 changes.
After pushing from the DEV side, this interface seems to be completely useless to me. As a reviewer I want to re-check the code adaptions. So when checking the interface many things are "outdated" now. I cannot see the change. Or they are still valid, but I can also NOT see the change.
I definitely remember on prior versions to be able to see all the changed parts of code, even with those comments.
For me it's really hard to work on those comments now.
Do you have and ideas / suggestions / proposals for that way?
All the best, stay safe!

[hackwithharsha]

Thank you good tip, I will share this with my team.. subscribed !!

[tejasdevraj]

Thanks a lot!! Simple and straight to the point!!

[mehmetkazanc]

Thanks a lot for this fast and informative content.

[cankatmert]

Thanks for this short and informative video.

[uduinjr]

Thank you very much!!
btw the limit time is not necessary I think 🤔

[gergitokusse]

How do we make highlight for the specific line we went to comment

[valp_co]

Thank you dude, it's a valuble and concise info.

[jonesgabriel]

great video Dave! this was super helpful

[luisfelipesantillanmondrag]

amazing, I made my first review using this today! thanks @CoderDave

[wolfgang]

nice, keep it simple !! thank you very much man !!