Do product managers know how to code? #softwareengineer #productmanagement #codingchallenge #python

[jjn]

Using print hello, she a real one confirmed

[jozkobranko]

scratch the whole code and write it from 0 😎 ez

[_greysama_]

She did better by going step by step while debugging being a product manager

[sonnyakakitha]

Low = mid + 1 else High = mid, in several cases the binary search It can be cycled, it’s best to have an approach either lower bound or uppee bound

[SwiftAndDroid]

1)while (low <= high)
2)Return True
3) if (target> midValue: low= mid+1
4) else high= mid-1
Outside while return false

[azophi]

“Return target in list”

Python moment 😢

[aliendroid]

The moment she used a print to determine where the Issue starts I already knew she knows her stuff

[freashty]

I dont beliebe that this is a real product manager

[kanishyathra]

Return False should be have one less space so it dont return false immediately when we do first try in the while loop.

[jurnygamer]

No problem with high = len(list), just depends on what your representation of the interval is.
Left is usually closed by convention, right can be closed or open:
len(list) -> is number in some index in [low, high[
len(list)-1 -> is number in some index in [low, high]
The updates are defined accordingly:
If mid<target: low = mid+1
Because we know that target is not in [low, mid] so we remove that interval.
If mid >target:
We know that target is not in [mid, high] or [mid, high[ (depending on choice of high) so we remove that interval and we get
[low, mid[ = [low, mid-1] and update high accordingly (high = mid if open on the right, high = mid-1 if closed)
Pretty simple to prove that if the element exists then it is always in the remaining interval and the size of the interval is strictly decreasing at each step so it always terminates

[Joe-kuko]

The problem at the end is that the return False at the end is inside the loop, not outside, which is a bug.

[akansha]

low=mid+1, high=mid-1, and return false out of the while loop

[iprxvsj]

Apparently the return false statement is put at the wrong place or so-called indentation😅

[EggiBoi]

im just asking but some of these errors can be found just by looking at the code and guessing what the result should be or am i wrong?

[cme]

In the else statement, was there any need to return false? Since the else takes care of it

[HikaruAkitsuki]

I forget to use Python since I switched to JavaScript, but I can say that I have no idea what the heck is she doing.

[amiganer]

A maybe Integer-Overflow bug: The line "mid = (low + high) // 2". By adding the integers first, they can overflow. A "mid = low + (high - low) // 2" is more robust and the integer is not overflowing.

[robinpark]

The return false is in the while loop smh...

[myst]

the way i saw it n first thing i realized is binary search is crazy. btw i dont even code

[isstylertho]

Move return False statement out of while loop