Code Review: Spec-compliant URL parser

[spawnlink]

“Make it work, then make it beautiful, then if you really, really have to, make it fast. 90 percent of the time, if you make it beautiful, it will already be fast. So really, just make it beautiful!” - Joe Armstrong (Erlang co-creator)

[zackh]

who is Earl and why are we parsing him :^)

[soko]

Let's watch this genius code instead of finishing my own work, acceptable procrastination.

[ne]

Tfw you'll never be a viking leet programmer with a god like work ethic.

[berndeckenfels]

44:06 in Java a StringJoiner can inert prefix/suffix optionally, if you want to extend your string util some more.

[tiagu]

Good boy Earl finnaly getting compliant

[berndeckenfels]

38:00 There was an article on clear keywords for making comment clear if yo want changes if you have a question or just want to record a finding. Can’t find it anymore, but it was something like „please change:“, „confirm: good catch“, „Observation!:“ and also emoticons as shortcuts could be. Standaized in your project

[sirdiealot]

I find these videos super enjoyable somehow.

[IAMSolaara]

The way you say "very tasteful" makes this all feel _that_ much classier

[spawnlink]

1:08:00 Yes. More types == better for this stuff. One could argue that usage of PoD types should be seen as an anti-pattern.

Meme Review has a colorful transition between the individual memes reviewed. I think Code Review should have something similar between the individual commits. :^)

[DavideMortara]

At 44:00 you talk about StringBuilder join behaviour. Why don't add a parameter to allow insertion of the first separator at the start?

[spawnlink]

re: string builder "micro opt"... I'm not sure I agree articulating the size is necessarily a "micro opt". I think, even if writing knowingly inefficient code, it is better to provide as much information as possible so that future self or future other person might have more context. Also, the implementation of string builder could change. Not to say in this situation any of this matters but seeing that code in a year I'd prefer to have the "hint" of 4 to know that the person didn't expect much data would be generated. Could help in refactoring.

[echoptic]

Since you are not going to work anymore, what will happen with commute talk?

[JBotAlan]

Oh man. If you went through one of my PRs commit-by-commit you'd probably think I'm a complete idiot lol

[berndeckenfels]

BTW just a general comment, compliant url parses are often not well suited for rl data, sometimes it migh be good to offer a lenient/smart mode (but then again maybe not?)

[VACatholic]

I'm a git newb. As much as I've used it, I've never "learned" it. Do you have some documentation on your `gap' command that you use to build commits like this? I really should learn how to do this stuff.

[berndeckenfels]

That list owhitspace seems not be complete for unicode. You could put a whitespace character class in a unicode class to make it complete and avoid the hardcoding (also for isWhitespace)

[spawnlink]

That switch state machine really should be broken down to functions per case. Collapsing scope is perhaps the most important way to improve reliability and testability.

[JannisAdmek]

Before I watch the video: Spec compliant URL parsong is very difficult and there are huge inconsistencies between different libraries and browser.