Real-Time Air Traffic Control Game! // Code Review

💰 Links to stuff I use:

This video is sponsored by NordPass Business.

[TheCherno]

What did you think? Do you want to see a Part 2? 👇

[johnclasing]

Thanks for reviewing this code. I'm not a pro by any means and I'm probably...not even knowledgeable enough to be SUPER dangerous I guess. I appreciate it anyways. I love code.

[Markus_included]

18:40 I saw a .idea directory, so i'm assuming they used CLion which redirects console IO into the IDE console, so the windows subsystem was never a problem. Also CLion sets the build directory to be the project directory by default, so that's the reason why the resources couldn't be loaded, because the build directory was "wrong".

[intptointp]

I’ll say, man. You bring a much-needed perspective of a production C++ engineer to Youtube, in my eyes.

Build problems, missing dlls, things like this…

They aren’t addressed in C++ tutorials or discussions on languages.

They also aren’t really taught anywhere at all, at least not where I know.

So you having a working perspective on C++ is very valuable to me.

[timlind]

Crazy how much goes into just setting projects up, build steps etc. just to get it running. But love that you do this, because this is so common when trying to get almost every project running locally.

[christopher]

The wildest part of this video was learning that C++ has NO NETWORKING IN THE STANDARD LIB, IN TODAY'S ECONOMY

[codemetas]

You are wrong about the singleton via Instance-functions being unusual or not useful!
It is a fairly common pattern in C++ code known as Meyers' Singleton which avoids certain issues with global objects, namely the static initialization order fiasco.
Furthermore, since C++11, it guarantees the initialization happens in a thread safe manner the first time the function is called.

Among others, the C++ Core Guidelines recommend this version (if you need a singleton at all, which I agree you rarely do)

[kubab]

It took so long coz it downloaded libraries and buildd them for you. Thats why 5 minutes. But then when you have them compiled, it takes up to 10 seconds

[paxdriver]

Would love to see the data fletcher and networking in a part 2, thanks a mil to you and the person who authored the code for submitting it.

[AndrewErwin]

I like how we are always talking about "roasting" code, but Cherno is about the most polite "roast master" on the internet.

[BboyKeny]

I would like a part 2. The code looks like it's not beginner level. The critique you're dishing out is very straightforward and bumps the code up to professional grade. With the active development on it, I can see the dev benefitting from a part 2 just as much as we can.

[antonpieper]

18:31 In Unix, you can start the program in the terminal using ./path/to/bin and then you would get stsout/stderr into your terminal

[Lorofol]

Love the points about decoupling the "engine" from the "game", fantastic feedback and incredibly valuable to think about how to "modularise" systems and interfaces in this manner.
Of course, for such a small project OR if the developer didn't intend to further use the engine; then I couldn't give a rats ass about the deep coupling.

[RaubeR]

18:40 When you launch as an end-user, you do so by tapping the app icon - no console. But as a "developer", you can open CMD and run the game from there, then you receive the logs there.

[Betacak]

It's incredible how different the build process can be on different machines and operating systems. I wanted to test it myself, so I downloaded the code, ran cmake, which told me that I was missing 3 dependencies (OpenAL, Vorbis and FLAC), but only took 40 seconds to run overall. Then I ran make, which took another 50 seconds. And after that, the game was playable with no issues.

[perelmanych]

Learnt a lot from mistakes of another. Demanding part II.

[Dakforever]

at 18:38 in linux it is common to have logging that doesn't get seen or saved anywhere unless you run from terminal, many programs are written that way. it is not always necessary to view logging unless there is an issue

[DavisTibbz]

Yay! "Everything" search utility is mentioned. Its pretty awesome

[TheCodeHunter]

Never thought I’d see the Cherno review an aviation based game

[mertcanzafer]

Yeah i liked the code in general even tho there were some redundant parts included as you said, but cool to see people having different styles to write codes. Hoping to see part 2 of this video😊