how programmers *actually* review code #programming

[severinevalles]

The "I don't really think you have the authority to ask me to do this but I did it anyway" is so on point

[GSBarlev]

... aaand the website crashes because something downstream was depending on the splash image being named default.jpg

[rajahfyed]

Using interns for quick reviews is so real

[AlbatrossCommando]

You're telling me you don't even have a C++ to React transpiler? This will need to be addressed at the next sprint.

[toboldgoodbody]

My biggest learning as a code reviewer was, to always think “is it worth the effort to do the change?” That stops suggesting many things that are just about taste and not actual functionality.

[z-beeblebrox]

At a previous QA job my supervisor set up a testing version of the home page that was designed to automatically display every possible image/banner layout the home page would ever be used for, with placeholder images, and LET ME TELL YOU the CRISES that were averted because we ran this case every update - NEVER underestimate the power of a single stupid image to completely break a website.

[chairedge]

"The text boxes you have added to the cans weren't sanitized. You didn't do integration tests. Some script kiddie yesterday pulled our entire database through it."

[sumofty]

I sighed out loud when this got pulled in for a design review. Good work

[luigif]

"Thanks for fixing this urgent bug in code that someone else wrote and that had no tests. Now can you add tests to this code you didn't write in the first place? You can't merge it until you do, and the person who caused this won't care"

[XDawesomeness]

“What would we possibly even be integrating with” famous last words lol

[Thoringer]

Funny thing: To be ADA compliant, you actually need an alternate text for every picture. Not sure what the law says about companies, but when I was responsible for a tiny part of - meanwhile 2 - universities, I had to make damn sure that nobody had the foolish idea to upload a flyer for an event as picture. No no no! That needs to be either text or you need to also give me the same info in text form so bowser plugins for the blind and visually impaired can read it to them.
In this example, naming the picture two_water_cans_highfiving_on-beach.jpg, for example, would suffice because then the name is descriptive. (But it doesn't hurt to have that as title string as well.)

So, the really frustrating part is that, yes, I really needed to review this because even if only about 2-4 people actually wanted to upload something, somehow, they never could remember that part. At that point, I just did all of that myself. Also tested it. Luckily, the system we had had a preview before commit.

[christianvalente]

"its okay i just updated an image!"
Load-Bearing TF2 Coconut: 🤔

[mike]

If Youtube shorts teach me anything it's that being a dev in a small business seems way less stressful than a large business. My commit message says "this was super annoying" And it's approved with no questions

[justafreakable]

Ahh those passive aggressive thanks at the end 😂

[dorktime]

When someone asks for a test that makes no sense, I say I wrote it in a way that already fits into an existing integration test. Because someone that doesnt understand why something wouldn't need a test would also not understand that lie.
No fuss and no passive aggressive commments required!

[rishabhanand]

Using the intern is all well and good unless the other person used the "request changes" feature, meaning the pr can't go through without their approval specifically

[SteinGauslaaStrindhaug]

To be fair, some of the silliest bugs I've ever committed were typos in rather trivial non-logic changes. But just linting, building and having someone proofread the human readable data was usually sufficient to find the errors.. in fact I usually find the error myself when I look through the diff while creating a pull request.

[Evilanious]

I've been on both sides of this one. I've also left reviews with 'hey, this doesn't even do what it was supposed to, can you meet the actual requirements' only to be told that that seemed like a lot of work.

[GustinJohnson]

The code is not written in C±+ brought back some memories

[JCAtkeson]

God I hate pull requests. The reviewer, AKA God, stalls for a week until the main branch doesn't match your code anymore, so you have to rewrite, re-review, and start over. Rinse and repeat forever while you send out resumes.