Terraform Code Review: Azure DevOps Build Agent PART 1

CODE REVIEW EPISODE 4 - PART I
In this episode, we'll analyze an audience member's Terraform code that provisions a Virtual Machine with a Virtual Machine Extension configured to setup the VM as an Azure DevOps Build Agent so you can run your Azure DevOps build pipelines on it. The original author cited some issues with the VM Extension installing correctly so we'll analyze their custom script to see if we can make heads or tails of the situation!

Follow me on Twitter for quick code snippets and thoughts on Cloud, Automation and other things!

Keep the knowledge flowing!

[CarlintVeld]

Key vault today has this Azure RBAC mode which I prefer compared to access policies mode. It is cleaner as it is using generic role definitions instead of this list of desired operations.

[marsamuk]

Hi. I'm trying to update Packer on my self-hosted Ubuntu agent within Azure. The challenge is that the agent doesn't have internet access. How can I update Packer in this offline setup? Appreciate your guidance!

[CarlintVeld]

I am not a big fan of variable files. I tend to keep the root module variable free and use a root module per environment. Inside the root module I call to a generic infrastructure that takes environment specific settings. In this way I can reference data resources and use the full hcl expressiveness to produce the environment specific settings. I can even declare additional resources for a particular environment if that makes sense instead of factoring that into the generic infrastructure module.

[CarlintVeld]

The original author has his PAT included in the scriptfile. You should never commit secrets into code. They should come from an external source at runtime.