3 lines of code vs 30k 😵😵‍💫

[blueredingreen]

Plot twist: the 30k lines could've been written in 3.

[MechMK]

The most horrible commit I've ever seen broke a feature. It contained two changes: The change that broke the feature, and the change that disabled the tests that detected the feature being broken.

[laurensholthof]

What's ironic is the fact in the first snippet of code it says ++ which isn't a thing in python, and yet she's complaining about the naming

[steveneccles]

PR that REMOVES 30k lines? Bang. Approved. No further questions, thank you, valued team member.

[AugustusGrochau]

I'd argue that gaseous sphere is more specific than bubble; not every bubble is spherical after all

[GreyJolly]

That's when you use the old reliable:

Looks good to me!

[falkland_pinguin]

Who's constantly updating the array sparklingwater? There's so many new bubbles popping up and old bubbles popping at the surface every second...

[MsPBJTime]

Oof. The sad fact is that the 30k change is a full new feature that is part of a flagship SaaS product launch that is due today at 10 AM Pacific. It's 8 AM. I might be speaking from experience as a PM who wants to become a developer.

[GSBarlev]

This is why I have such mad respect for folks like Linus Torvalds who will just flat-out reject big PRs, especially right before the end of a merge window. It's on the reviewer to accept the risk of a PR. It's on the PR author to justify that acceptance.

[JonBrase]

Bubble sort on half a billion items?

Of course! We're a sparkling water company!

[steggopotamus]

I love your blend of energy, enthusiasm and practicality. It's sort of like the secret blend that Hank green has for science, but for tech and AI (and a different blend obviously)

[mcmaddie]

30k line pullrequest will be denied right away to be split in smaller pieces.

[HistoricaHungarica]

"This way we can count farts in the product as well and than sell it as bubbles!"
Corpo mentality.

[johnwest]

I watch these to remind me why I retired.

[SlyIfrit]

Sounds about right. No one is going to look at the 30k line code review. This is how bike-shedding works in general. Everyone has an opinion on the simple stuff.

[ChaserX]

In chemistry we also call the formation of bubbles "nucleation." That seems like a smart word, let's use that instead of "formation of bubbles."

[dacjames]

This is so true. Experienced reviewers learn to simply reject the second PR out of hand. Otherwise, you create a perverse incentive to create large, complex PRs as a means of circumventing detailed review.

[likesubstance]

The first example actually made me angry, which seems to be the point so good job🤣

[connorskudlarek]

Plot twist: the 30k lines are all nested if statements and callbacks

[alxk]

There are only two hard things in computer science. 1) naming things 2) cache invalidation 3) off by one errors