justforfunc #4: Code Review for a Twitter client

New studio, new camera, new code review!

I hope you like it!

[neknarqo]

Another great episode! Thanks for doing it.
I think it's worth mentioning that parsing env variables inside the stream client is another thing that one wouldn't expect from the client. I'd be much happier if credentials were passed to the NewStream "constructor" as arguments. What do you think?

[EcumFauz]

Awesome! These code reviews are really helpful especially for a newbie in go. Thanks a lot!

[sweetmoment]

Raphael, this is very inspiration man ! thanks for taking time and help the community

[alexgordon]

Great video! Keep it up! Nice new studio setup.
But I have one question.
At 32:16 you removed global vars green, underlined, yellow and then moved color.New(....).SprintFunc() in newModifier,
so color.New will be called a lot(possibly), because we use newModifier in for-loops. Is it ok?

[dc]

So all you need to do now is a "code review" of your recording process and voilà, one video per day! Looking forward to it :) Great video.. thanks for sharing!

[Orww]

Very informative Fransesc, keep it up! Also, awesome studio :) Thank you

[sunsin]

thank you! awesome format. please more

[celica]

I like how you always remind your viewers to not try to steal your consumer / client secrets :P we're nice people

[ivansimonik]

I'm hesitating if this is a Code review, I would say, it is refactoring as hell :-)

It's quite interesting to follow your thoughts however I would disagree with moving authentication values grabbed from ENV into library itself. This should be passed to NewStream() explicitly - not to force library users setting env (maybe the main application will use another source for authentication values than env).

I agrre with removing Ctrl+C signal from library, but your argument "using this twitter package in different library - in a web server for instance" is a little bit weak, because this library produces stream formatted using terminal ANSI color escape sequences.

It's definitely worth to see your presentations (I personally like your presentation from GopherCon about nil) I'm gonna to watch the previous episodes...

[RonaldSuez]

Nice episode man ! keep it up! many thanks

[KacperPerschke]

Two questions:
1) Could HandleTweet be named FormatTweetForTerminal?
2) Could formatting be made using text/template?

[paulyeoh]

Thank you! Learnt a ton, every minute was worth while.

[TheNullBox]

Wouldn't it be better to use the package `context`, instead of returning a handler to close()?

[mybigbeak]

Awesome video. I feel I learned so much from this. Long is fine if everything is interesting/helpful. Thanks.

[AnthonyVoutas]

Thanks for another great video, Francesc. You got me wondering does defer work the same in main as it does in other functions or is main special?

[LizardanNet]

Why 8 spaces for indent? looks like a waste of space.

[dreamtheater_]

This is great, but I wouldn't call it a code review. It's much more like a refactoring exercise. How about a video covering "bad habits from other programming languages"? Idiomatic Go vs. C#/Java/Python, etc.

[kgarbaya]

I am learning go and I made a library that consume Rest API and would love to get a review from you also if you don't mind, i can send the github link

[ErShara]

cd: no such file or directory: gitlab.com/hackebrot/tweets

[Criteria]

i should but a comment on the mistake at 0:09