Code Review // Game Engine (PSP, PsVita & Windows)

preview_player
Показать описание
Looking through your projects live
Рекомендации по теме
Комментарии
Автор

Nathan, regarding the black screen on twitch: check your bitrate in OBS. If it's too high for twitch, you'll just get a black screen. Twitch typically recommends 6000 kb/s as a max, although it does allow you to go higher than that. I've seen one place saying exceeding 8500 kb/s will lead to the black screen.

Bobbias
Автор

54:21 regarding the raw new into a static vector. It will be freed when the program closes and the variable has static lifetime so leaking in that way isn't so much of a problem.
But you also have to consider other cases, what if someone mutates the vector in some other way and those raw pointers are lost or changed without being deleted.
Also, what if someone calls Shader::Init() twice, is the behaviour you want for new copies of that allocated object to coexist with the previous copy or would you want the previous versions to be cleaned up first?
RAII and/or smart pointers can simplify the code and protect you from mistakes.

KX
Автор

Your subscriber notification thing is quite distracting to me, not least because the sound effect is the same sound effect I get from temperature alarms on the blood fridges at my work.

KX