code review is too late for code quality (github universe 2021)

preview_player
Показать описание
here's my talk from github universe 2021! I talk about using automated tooling (pre-commit) such that you can focus on what really matters for code review!

==========

I won't ask for subscriptions / likes / comments in videos but it really helps the channel. If you have any suggestions or things you'd like to see please comment below!
Рекомендации по теме
Комментарии
Автор

Awesome! Thank you so much for your work anthony. I started learning python two years ago and have learned so much from your videos since then. Pre-commit is by far my favorite tool to use when programming in python. I get absolutely excited every time I recommend it to someone new and so far everyone has come to love it. Please keep up the good work and I hope more people will see your videos and livestreams in the future ❤

dozy
Автор

Damn Anthony. You lookin' sharp in this presentation!

ItzAnameOk
Автор

wow! awesome anthony. i love that it's language agnositc

bulelanibotman
Автор

Super clear and very helpful ! Thank you 🙏 Anthony

alexandreboisselet
Автор

I see you finally got to making that pre-commit video lol. Fun vid. Have been really enjoying using pre-commit btw. Good job.

AceofSpades
Автор

Anthony looks very kawaii when doing this presentation ☺️

roshanjrajan
Автор

Thank you too! I was wondering whether there any good plugins for a pre-commit hook to enforce pythonic code style? For instance, using try/except for dictionary lookups, not comparing True to True when returning?

d
Автор

I did not understand one thing for ci tool you presented. Would it be possible to have a github action instead running linter and formatter on the code? And then adding the changes in a separate commit to the PR? (All instead of running external pre-commit ci)

d
Автор

very nice presentation! (but boooo ann arbor go bucks). I know that I should probably start using some kind of linter, but it is hard to convince myself to do the setup at the beginning of a project.

jtwarfield
Автор

I noticed that our formatter (black) fixes some of the flake8 errors, but not the ones with existing unused imports. Can’t we have that working too?

How does a formatter know about the previous errors from flake8 that it needs to fix?

d