Amazing Code Reviews: Creating a Superhero Collective • Alejandro Lujan • GOTO 2019

preview_player
Показать описание
This presentation was recorded at GOTO Berlin 2019. #GOTOcon #GOTOber

Alejandro Lujan - Senior Data Platform Engineer

ABSTRACT
Are you a bit terrified when merging to master? Do you loathe having to read hundreds of LOC to understand that PR you got tagged in? Do you polish and re-polish before asking for a review? Then you should come to my talk. We’ll talk about how your team can be awesome at reviewing code.
There is general consensus on the fact that code reviews are an important step for a successful development workflow. Most organizations undergo code reviews of some form.
However, it’s all too common to see reviewers that barely scratch the surface of the work being put forth, or that offer feedback that is unclear or hard to act upon. This robs the team from the opportunity to speed up learning, share knowledge and context, and from generally raising the quality bar on the software being built.
In this talk, I will share my story of encountering a new code review process when joining Shopify, and the surprising learnings I found - even as an experienced developer. I will discuss the tremendous gains individuals and teams [...]

Read the full abstract here:

#CodeReviews #DeveloperProductivity #Productivity

Looking for a unique learning experience?

SUBSCRIBE TO OUR CHANNEL - new videos posted almost daily.
Комментарии
Автор

I like the idea that Code review spread the ownership through the team

myobpro
Автор

I was on a very small team that did most of this stuff well and it was magic. A three person team managing a digital curriculum for hundreds of thousands of students. The real place one finds 10x productivity is in a cohesive team.

JeremyAndersonBoise
Автор

Offer positive feedback during code reviews too! Like this a lot.

JungleBeats
Автор

"Great companies invest in people for the long-term. Great un-rushed code reviews are a part of that. We could prioritized landing shit in the short term and we will right the same shit forever or we can prioritize making you a stronger contributor. And all of your future contributions will be better and your career brighter. An enlightened author should be delighted to have this attention."

atharvawankhede
Автор

Wow! a very good session!
Thanks Alejandro Lujan and GOTO!

islamh
Автор

this video was mentioned in betterDev #136 jan27'20 newsletter

pryl
Автор

D'you know if are there the slides somewhere, pls?

emanuele
Автор

This speaker has something quite fascinating going on with his pronunciation.... where he's mixing his original Venezuelan Spanish with his new Canadian English, some words at the end of sentences come out sounding Irish????

edgeeffect